[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] [PATCH] automatically filter disks with imsm or ddf superblocks, v2



According to Miquel van Smoorenburg:
> Here's version two of the patch. I've taken your comments into account,
> and I've also fixed some wrong assumptions (like size being in sectors,
> not bytes). It's been tested on both imsm and ddf formatted disks.

Hmm, I caused a small cosmetic bug when I implemented one of
your suggestions, this should fix it (I'l send a full patch as well):

--- a/lib/filters/filter-md.c	2012-09-16 21:05:34.000000000 +0000
+++ b/lib/filters/filter-md.c	2012-09-22 16:24:18.528609536 +0000
@@ -29,7 +29,7 @@
 		return 1;
 	
 	if ((ret = dev_is_md(dev, NULL)) != 0)
-		sb_type = "ddf";
+		sb_type = "md";
 	else if ((ret = dev_is_ddf(dev, NULL)) != 0)
 		sb_type = "ddf";
 	else if ((ret = dev_is_imsm(dev, NULL)) != 0)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]