[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] [PATCH] lvremove: perform retry logic also on -real subvolume for snapshots



Hi there,

Nevertheless, I think it might be a good idea to still apply my patch

Nope. They would mask problems - the code should already handle your
case at different level.

I would like to submit to you that even though lvremove itself might
not trigger the udev rules that conflict with it, some other program
might by accident at the same, which could still cause problems.

Or, to turn your argument around: if you really think that performing a
retry on the -real device when deactivating is not a good idea, then
conversely one should probably remove the retry logic also from the
main device. (Which btw. appears to work, I couldn't reproduce a
failure if I comment out the same lines in the 'case DEACTIVATE' that
are already there in the current git.)

That said, personally I believe that increasing the robustness of a
piece of software is generally a good thing; not failing unless
absolutely necessary seems to be a sound general policy to me. As for
masking the problem: simply printing a warning message in case of the
retry would be sufficient in my eyes to still notice if the
synchronization logic fails.

On the other hand, my main interest is that it works, which appears to
be the case with current git, so take my 2ยข or leave them at your
discretion; I'll now start pestering the Debian bugtracker to get the
issue fixed there.

Anyway - before reporting any udev synchronization problem - always
check with upstream git and udev rules first - since the Debian
version is usually significantly changed in this area....

I didn't know that the Debian patches were that invasive, sorry.

Thanks,
Christian


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]