[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] [PATCH] lvremove: perform retry logic also on -real subvolume for snapshots



On 07/30/2013 05:18 PM, Christian Seiler wrote:
> This commit is a follow-up on the first change. If the last snapshot of
> a volume is removed, the -real subvolume is not removed via the
> codepath that has the retry logic, but by just doing a cleanup of
> unused volumes. This means that spurious failures may still occur,
> although not as often.

These subvolumes should already be properly marked with flags
we attach to them during their creation - these are then sent
encoded in uevent and udev rules are skipped based on it,
including skipping the WATCH udev rule.

> 
> This patch adds the same retry logic to the cleanup codepath in order
> to make it even more unlikely that such a spurious error may occur.
> 

..but yes, we could probably add this patch to make sure something
like that does not happen at all.

But still it would be better to look why those spurious events
are triggered for non-top-level volumes (it's possible the
OPTIONS:="nowatch" in some case, I'll check...).

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]