[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [linux-lvm] [Yum-devel] [PATCH 4/2] fs snapshot plugin: add LVM tag to allow tools to link pre and post snapshots



On Tue, 2013-03-12 at 14:09 -0400, Mike Snitzer wrote:
> On Tue, Mar 12 2013 at 12:41pm -0400,
> James Antill <james fedoraproject org> wrote:
> >  Using globals should work, the only real problem is if some python API
> > creates multiple YumBase() instances (but although we've worried about
> > that, nothing has ever really done it AFAIK).
> 
> Just adding a single global caused the plugin to fail: global foo = None

 That's a syntax error, python is much more annoying about globals than
perl (or pretty much any other language :).
 Also note that you can pass "-d 9" (maybe even just -v) to yum get the
traceback from plugins, we suppress them on load, by default, as that's
much better for users.

> abs(hash(tsInfo)) should be sufficiently unique when coupled with
> futureRpmDBVersion().

 Probably, I was just worried that in some cases it might have similar
addresses (given it's doing mostly the same work each time, without some
kind of memory randomization it might well be at an identical memory
address).

>   But yeah, I didn't know how to store the timestamp.
> 
> I'll send a simpler v3 now.. thanks for your help!

 Looks fine, I've pushed it and built it in rawhide (on F19 branch too).



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]