[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] Re: [LVM2 PATCH 1/2] lvrename: add mirrored LV support




On Jul 27, 2007, at 10:32 AM, Jun'ichi Nomura wrote:

-	if ((lv->status & MIRRORED) ||
-	    (lv->status & MIRROR_LOG) ||
-	    (lv->status & MIRROR_IMAGE)) {
-		log_error("Mirrored LV, \"%s\" cannot be renamed: %s",
-			  lv->name, strerror(ENOSYS));
-		return 0;
-	}
-

I don't think you want to remove this wholesale. Testing reveals that you are allowed to change a sub-lv name by itself, which is not something we want, I don't think. Instead, leave the checks in for MIRROR_LOG and MIRROR_IMAGE.

 brassow



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]