[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [LVM2 PATCH 1/2] lvrename: factor out core routine



On Fri, 2007-07-27 at 11:32 -0400, Jun'ichi Nomura wrote:
> Hi,
> 
> This patch factors out core renaming function from lvrename()
> as a preparation for mirrored LV renaming.
> 
> No functional change except for the order of the validity check.
> It used to be:
>   - check if the new name is not yet used in the VG
>   - check if the old name really exists in the VG
> This order is now reversed.
> As the VG is locked, it should have no problem.
> 
> Also the following cleanups are included:
>   - converting "stack; return 0;" to "return_0"
>   - removing duplicated mirrored LV check
>     (there were 2 identical checks)
> 
> Applicable to the CVS head.
> 

This looks fine and is a nice cleanup.  Will probably move the new
function out of the tools dir though.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]