[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] RFC: testing framework



Jun'ichi Nomura wrote:
> Jim Meyering wrote:
>> There are kludges in t/Makefile.in (symlink creation and LD_LIBRARY_PATH
>> setting), that are required to run the dynamically-linked lvm against the
>> libraries in a just-compiled sibling device-mapper directory.  Thanks to
>> Dave Wysochanski for that tip.  IMHO this is a very strong argument
>> for pulling device-mapper into lvm.  Alasdair, can we do that soon?
>> I'll be happy to submit a patch.
> 
> It didn't work for me because I have device-mapper source directory
> named '../device-mapper.work', instead of '../device-mapper' that
> Makefile assumes.
> There is '--with-dmdir=DIR' option for configure.
> Can the Makefile use it?
> (A patch is attached.)

Also, this patch to allow relative path for '--with-dmdir' might
be helpful.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
Index: LVM2.work/configure
===================================================================
--- LVM2.work.orig/configure
+++ LVM2.work/configure
@@ -9621,6 +9621,9 @@ fi
 
 # Check whether --with-dmdir was given.
 if test "${with_dmdir+set}" = set; then
+  if (echo ${with_dmdir} | grep -qv "^/"); then
+    with_dmdir="`pwd`/${with_dmdir}"
+  fi
   withval=$with_dmdir;  DMDIR="$withval" CPPFLAGS="$CPPFLAGS -I$DMDIR/include"
 else
    DMDIR=

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]