[lvm-devel] revised error output: Run ... --help for more information

Alasdair G Kergon agk at redhat.com
Fri Sep 21 11:53:30 UTC 2007


On Fri, Sep 21, 2007 at 01:30:03PM +0200, Jim Meyering wrote:
>     $ ./lvchange
>       Need 1 or more of -a, -C, -j, -m, -M, -p, -r, --resync, --refresh, --alloc, --addtag, --deltag or --monitor
>       lvchange: Run `lvchange --help' for more information.
 
So we should certainly drop the 'lvchange:' now from the second line of output.

>       lvchange: Need 1 or more of -a, -C, -j, -m, -M, -p, -r, --resync, --refresh, --alloc, --addtag, --deltag or --monitor

So should we add a new option (command_names = 2, perhaps)
that only applies it to messages produced using log_error()
rather than for all output?  [And make this the default setting.]

Or do we only want it (roughly speaking) for EINVALID_CMD_LINE not for
ECMD_FAILED?

Alasdair
-- 
agk at redhat.com




More information about the lvm-devel mailing list