[lvm-devel] revised error output: Run ... --help for more information

[Jim Meyering]

Alasdair G Kergon <agk at redhat.com> wrote:
> On Fri, Sep 21, 2007 at 01:30:03PM +0200, Jim Meyering wrote:
>>     $ ./lvchange
>>       Need 1 or more of -a, -C, -j, -m, -M, -p, -r, --resync, --refresh, --alloc, --addtag, --deltag or --monitor
>>       lvchange: Run `lvchange --help' for more information.
>
> So we should certainly drop the 'lvchange:' now from the second line of output.

Good.  It's already gone in my current sources.

>>       lvchange: Need 1 or more of -a, -C, -j, -m, -M, -p, -r, --resync, --refresh, --alloc, --addtag, --deltag or --monitor
>
> So should we add a new option (command_names = 2, perhaps)
> that only applies it to messages produced using log_error()
> rather than for all output?  [And make this the default setting.]
>
> Or do we only want it (roughly speaking) for EINVALID_CMD_LINE not for
> ECMD_FAILED?

Personally, I'd like the "command_name: " prefix
on all "real" diagnostic lines -- and that'd be consistent
with what other tools do.  In my experience, the "Run ... --help"
diagnostic is most useful on EINVALID_CMD_LINE failures.