[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Make _init_rand() thread safe - use rand_r() instead of rand().



On Fri, Dec 05, 2008 at 05:52:45PM -0500, Dave Wysochanski wrote:
> This random code is for temp files.  Other code which uses
> /dev/urandom is used for uuids.  Should we be using /dev/urandom
> everywhere?
 
Well look what we are using it for - we are not relying on the randomness
- if the filename is already in use, we just try another one - so it's
nothing to worry about.

> +	if (!create_temp_name(temp_dir, temp_file, sizeof(temp_file), &fd,
> +			      &vg->cmd->rand_seed)) {

Just pass 'cmd'? (as first arg)

Does this patch do enough to ensure each thread will get a different value of
'seed'?

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]