[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 06/11] Remove archive_enable() calls after create_toolcontext() calls.



On Wed, Dec 10, 2008 at 01:10:56PM -0500, Dave Wysochanski wrote:
> The archive_enable() call we remove
> here was using cmd->current_settings to set the 'archive' enable
> value.  

Does that make archive_enable() unused?

> -	if (!archive_init(cmd, dir, days, min)) {
> +	if (!archive_init(cmd, dir, days, min,
> +			  cmd->default_settings.archive)) {

Call archive_enable() here instead, or have archive_init() call it
internally or comment out the function as unused?

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]