[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 11/11] Move initialization of cmd->fmt into init_formats().



On Wed, 2008-12-10 at 22:56 +0000, Alasdair G Kergon wrote:
> On Wed, Dec 10, 2008 at 01:11:01PM -0500, Dave Wysochanski wrote:
> > diff --git a/lib/commands/toolcontext.c b/lib/commands/toolcontext.c
> > index 186a816..e66972c 100644
> > --- a/lib/commands/toolcontext.c
> > +++ b/lib/commands/toolcontext.c
> > @@ -787,6 +787,7 @@ static int _init_formats(struct cmd_context *cmd)
> >  			return 1;
> >  		}
> >  	}
> > +	cmd->fmt = cmd->default_settings.fmt;
> 
> Move up just before the 'return 1' above?
> 

Indeed, that's an error.  Nice catch.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]