[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] (1/2) new library interface for vg_read



On Tue, 2008-12-09 at 17:44 +0100, Petr Rockai wrote:
>  /* FIXME: remove redundant vg_name */
>  int vg_remove_single(struct cmd_context *cmd, const char *vg_name,
> -                    struct volume_group *vg, int consistent,
> +                    struct volume_group *vg,
>                      force_t force __attribute((unused)))
>  {
>         struct physical_volume *pv;
> @@ -340,7 +340,7 @@ int vg_remove_single(struct cmd_context 
>         unsigned lv_count;
>         int ret = 1;
>  
> -       if (!vg || !consistent || vg_missing_pv_count(vg)) {
> +       if (vg_read_error(vg) || vg_missing_pv_count(vg)) {
>                 log_error("Volume group \"%s\" not found, is
> inconsistent "
>                           "or has PVs missing.", vg_name);
>                 log_error("Consider vgreduce --removemissing if
> metadata "

Did you mean to put this in the second patch?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]