[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] Re: LVM2 ./WHATS_NEW_DM libdm/libdm-deptree.c



On Thu, Dec 11, 2008 at 11:35:23AM -0500, Dave Wysochanski wrote:
> 
> > +/* simplify string emiting code */
> > +#define EMIT_PARAMS(p, str...)\
> > +	do {\

> Do we have to do a macro here?  Macros like this are harder to debug...

Indeed - but sometimes there's stuff that's just too awkward to do
as a function.  I don't mind this one - we have a similar one in the kernel
called DMEMIT - so long as it is correct:-)
 
Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]