[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] New public functions lvm2_reload_config, lvm2_set_config_option and lvm2_reset_config_option.



On Fri, 2008-12-12 at 12:36 +0100, Thomas Woerner wrote:
> >> diff --git a/lib/lvm2.c b/lib/lvm2.c
> >> index daf9a79..ac5e583 100644
> >> --- a/lib/lvm2.c
> >> +++ b/lib/lvm2.c
> >> @@ -15,6 +15,30 @@
> >>  #include "lvm2.h"
> >>  #include "lib.h"
> >>  #include "toolcontext.h"
> >> +#include "archiver.h"
> >> +#include "activate.h"
> >> +#include "../tools/tools.h"
> >> +
> > 
> > Do we need the relative path here?
> > 
> Ok, I will add tools/tools.h, tools/toollib.h, tools/commands.h and 
> tools/args.h to include/.smylinks. Then it is possible to use
> #include 
> "tools.h".

Actually, including tools/*.h header files in a library file is not
good.  If we need to do that we should probably try to refactor
something.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]