[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] [PATCH] Fix error message for mirror log allocation failure



In the course of pvmove/lvconvert restructuring,
an error message for pvmove was copied in to mirror log
allocation code.

Attached is a patch to fix it.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
Fix error message for log allocation failure.
(Was copied from pvmove code.)

[Older version of LVM2]
# lvconvert --mirrorlog disk vg/lvol0
  Insufficient extents for log allocation for logical volume .

[Current code without the fix]
# lvconvert --mirrorlog disk vg/lvol0
  Insufficient extents for log allocation for logical volume .
  Unable to allocate temporary LV for pvmove.

[With the fix]
# lvconvert --mirrorlog disk vg/lvol0
  Insufficient extents for log allocation for logical volume .
  Unable to allocate extents for mirror log.

Index: LVM2.work/lib/metadata/mirror.c
===================================================================
--- LVM2.work.orig/lib/metadata/mirror.c
+++ LVM2.work/lib/metadata/mirror.c
@@ -1281,7 +1281,7 @@ int add_mirror_log(struct cmd_context *c
 			      0, 0, log_count, 0,
 			      allocatable_pvs, alloc, parallel_areas);
 	if (!ah) {
-		log_error("Unable to allocate temporary LV for pvmove.");
+		log_error("Unable to allocate extents for mirror log.");
 		return 0;
 	}
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]