[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] (5/11) vg_read error returns, part 1



Dave Wysochanski <dwysocha redhat com> writes:

>> -int vg_check_status(const struct volume_group *vg, uint32_t status)
>> +static int _vg_check_status(const struct volume_group *vg, uint32_t
>> status)
>>  {
>> +       uint32_t ret = 0;
>>         if ((status & CLUSTERED) &&
>>             (vg_is_clustered(vg)) && !locking_is_clustered() &&
>>             !lockingfailed()) {
>>                 log_error("Skipping clustered volume group %s",
>> vg->name);
>> -               return 0;
>> +               ret |= FAILED_CLUSTERED;
>> 
>
> Need uint32_t for function return value consistency with internal
> variable.  Probably want to move/fix the comment as well.
Good catch, noting down.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]