[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel][PATCH 1/4] Udev integration: add LVM fields support for dmsetup



On 04/21/2009 08:35 PM, Dave Wysochanski wrote:
> A couple minor cleanup comments for this patch set:
> 1. Warnings when compiling these patches. 
> ioctl/libdm-iface.c:867: warning: no previous prototype for ‘dm_cookie_supported’
> dmsetup.c:332: warning: assignment discards qualifiers from pointer target type

Yes, I've noticed, too :) I've added proper casting here, so it's OK now...

> 2. whitespace / tabs - set to 8 spaces / tab?
> Areas I noticed were dm_cookie_supported() definitions and other
> indents.

...ok, I'll have a look

Thanks

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]