[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] lvconvert --repair



Petr Rockai wrote:
> Milan Broz <mbroz redhat com> writes:
>> please try this test - it tries to allocate new log - not sure if it is what we want,
>> but lvconvert fails but log lv is later visible, vg is still inconsistent
>> and I am confused what the correct state should be:-)
> The problem was that the code neglected to write out the consistent volume
> before trying to add new bits (which could obviously fail). The attached
> version of the patch fixes that (it also contains your test now).

Just minor things:
- some chunks (repairing vgreduce return code etc) are now already upstream
- there is also trivial merge problem, I am sure darcs merge code handle it:-)

- please check and remove some trailing whitespaces

- consider using vg->vgmem instead of cmd->mem - VG is locked
for the whole operation and failed PV list make sense only for that VG

- please add -i parameter to lvconvert in test script - it waits too long in tests

- add man page entry ;-)

Otherwise

Acked-by: Milan Broz <mbroz redhat com>

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]