[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] LVM2/lib/metadata pv_map.c



On Thu, Apr 23, 2009 at 04:41:28PM -0000, mornfall sourceware org wrote:
> 	Do not include MISSING_PVs in allocation maps.
 
Ack.

WHATS_NEW ?

> +		assert(pvl->pv->dev);
  
Please don't use 'assert'.  It bypasses our logging mechanisms
and aborts the code making debugging harder.

Use log_error() with an informative message instead, for example.

Alasdair
-- 
agk redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]