[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] A different implementation of --ignorelockingfailure.



Petr Rockai wrote:
> two ends are addressed by this patch: getting rid of some global state and also
> restricting --ignorelockingfailure to only allow what it is supposed to allow
> (instead of a few hacked-in checks at some places and our belief that the users
> will be well-behaved).

Acked-by: Milan Broz <mbroz redhat com>

--ignorelockingfailure should be used only to activate base volumes during boot,
(e.g. when /var/lock/lvm is read-only, locking is clustered but we just starting
clvmd or /var is on activated volumes itself etc)


Tested-by: Milan Broz <mbroz redhat com>

Some warnings (both are trivial)

locking/no_locking.c: In function '_boottime_lock_resource':
locking/no_locking.c:73: warning: suggest parentheses around comparison in operand of &

tools/toollib.c:1134: undefined reference to `lockingfailed'


If anyone want write test script for testsuite

- a) commands with locking_type = 1, /etc/lvm/lock mounted read only
- b) locking type 3 without clvmd running

 without --ignorelockingfailure it must fail,
 with that parm only vgchange, lvchange -a y/n should work

- transition from clustered->local->ignorefailure still works
(test combination of fallback_to_clustered_locking, fallback_to_local_locking)

Milan
--
mbroz redhat com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]