[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] [RFC PATCH 0/12] dm_report attribute handling and liblvm vg attributes



The purpose of this patchset is to get feedback on one approach to handling
attributes in liblvm.  The most important patches are:
1/12: Adds dm_report_output_attribute() function and related structures.
9/12: Updates vg_open to store vg attributes in the handle.  This allows us
to use the report memory safely (we free it in vg_close().
10/12: Add lvm_vg_get_attr_list() and lvm_vg_get_attr().

What is missing in the patch is the mode (read/write) of the attribute.
I have not thought extensively about this but one option is as follows.
Add a 'mode' or 'is_writable' field to the dm structure, and set it to
'readonly' for all attributes output by dm_report_output_attribute().
Then in vg_open(), depending on the mode and capabilities of the current
release of liblvm code, we can gradually change various attributes to
writeable.

This patchset should build fine but with some warnings.  Attribute code
was exercised with test code in last patch.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]