[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 3/14] Properly enforce cluster locking in _vg_lock_and_read.



Hi,

Dave Wysochanski <dwysocha redhat com> writes:
> With this patch, is there any point in leaving that CLUSTERED flag check
> in _vg_check_status()?  The clustered flag set in vg_read() is not
> needed either (check is mandatory now - flag doesn't mean anything).
actually, it seems you are right. I left it in because there are calls to
vg_check_status scattered through the code -- I didn't realize that it is now
redundant. However, there are still users of that check that are removed by
subsequent patches in the series. So to keep things working without requiring
all of the series to be applied, it should stay there. I'll remove it in an
extra patch on top of the stack.

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]