[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCHi v2 1/5] Update 'md_chunk_alignment' to use stripe-width to align PV data



On Sun, Jul 05, 2009 at 10:39:46PM -0400, Mike Snitzer wrote:
> +static unsigned long dev_md_chunk_size(const char *sysfs_dir,
> +				       struct device *dev)

> +	if (!(fp = md_sysfs_fopen(sysfs_dir, dev, attribute)))
> +		return 0;

> -		log_sys_error("fgets", path);
> +		log_sys_error("fgets", attribute);

Please reinstate the variable contextual information in these messages.
(sysfs_dir, dev, md are all now missing - return 'path' to the caller
of the customised fopen, or create the path in a separate fn first
and pass it in?)

> +static int dev_md_level(const char *sysfs_dir, struct device *dev)
> +static int dev_md_raid_disks(const char *sysfs_dir, struct device *dev)
> +unsigned long dev_md_stripe_width(const char *sysfs_dir, struct device *dev)

Is there more code that could be shared between these functions?

> +	data_disks = raid_disks - (level == 0 ? 0 : (level <= 5 ? 1 : 2));
Add a comment before that line explaining it.

Ack

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]