[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 6/7] Add vg_set_alloc() liblvm function and move vgchange logic inside.



On Tue, Jul 07, 2009 at 03:50:07AM -0400, Dave Wysochanski wrote:
> Add vg_set_alloc() liblvm function and move vgchange logic inside.

For the interface, we should probably say 'set_alloc_policy' rather
than just 'set_alloc'.

> +	if (alloc == vg->alloc) {
> +		log_error("Volume group allocation policy is already %s",
> +			  get_alloc_string(vg->alloc));
> +		return 1;
> +	}

It's back to 'change' vs. 'set' again:-)
If this input is acceptable now, either go for WARNING like we do in other
places where we proceed, or alternatively just reduce the message to
log_verbose if you don't consider it important.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]