[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 7/7] Add lvm_vg_create() - vg constructor API for new volume groups.



On Tue, Jul 07, 2009 at 12:34:27PM +0200, Milan Broz wrote:
> > +		if (!vg_set_extent_size(vg_to, vp_new.extent_size) ||
> > +		    !vg_set_max_lv(vg_to, vp_new.max_lv) ||
> > +		    !vg_set_max_pv(vg_to, vp_new.max_pv) ||
> > +		    !vg_set_alloc(vg_to, vp_new.alloc))
> >  			goto_bad;
 
> I like the old way much more better...
 
Applications using the defaults won't need to call any of those, and
eventually lvm2 tools should call them while processing any
corresponding cmdline args where non-default values are requested.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]