[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Do not fork daemon when dmeventd cannot be found.



Hi!

Milan Broz <mbroz redhat com> writes:
> diff --git a/daemons/dmeventd/libdevmapper-event.c b/daemons/dmeventd/libdevmapper-event.c
> index 2650cf0..dae76d3 100644
> --- a/daemons/dmeventd/libdevmapper-event.c
> +++ b/daemons/dmeventd/libdevmapper-event.c
> @@ -425,6 +425,12 @@ static int _start_daemon(struct dm_event_fifos *fifos)
>  
>        start_server:
>  	/* server is not running */
> +
> +	if (stat(DMEVENTD_PATH, &statbuf)) {
> +		log_error("Unable to find dmeventd.");
> +		return_0;
> +	}
Although not exactly spectacular, I guess this is fine. Just one thing, there's
an execvp later for DMEVENTD_PATH, so this may actually not be really a safe
check (DMEVENTD_PATH -> "dmeventd" should work without this check, but will
break with it).

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]