[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/7] Fix snapshot segment import to not use duplicate segments & replace.



Milan Broz <mbroz redhat com> writes:
> Simplify the code, snapshot segment is properly initialized
> in text_import function now and do not need to be replaced
> by vg_add_snapshot call.
Looks OK, although it does duplicate part of the code. Nevertheless, seems like
a better compromise than the previous one. Also, the ugly part of the code
where lv_count is fiddled manually is fixed by a later patch.

> The vg_add_snapshot() is now usefull only for adding new snapshot. The name
> is always gewerated, remove it from function call.
Ack.

> Signed-off-by: Milan Broz <mbroz redhat com>
Acked-By: Petr Rockai <prockai redhat com>

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]