[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 1/7] Fix snapshot segment import to not use duplicate segments & replace.



On Mon, May 11, 2009 at 08:27:13AM +0200, Peter Rockai wrote:
> Milan Broz <mbroz redhat com> writes:
> > Simplify the code, snapshot segment is properly initialized
> > in text_import function now and do not need to be replaced
> > by vg_add_snapshot call.
> Looks OK, although it does duplicate part of the code.

Indeed - please avoid duplicating that code.

Alasdair

 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]