[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] Re: vgimportclone: script to import SAN snapshots and clones



On Tue, May 12 2009 at 10:33pm -0400,
Alasdair G Kergon <agk redhat com> wrote:

> On Tue, May 12, 2009 at 06:47:25PM -0400, Mike Snitzer wrote:
> > Revised vgimportclone that should be ready for inclussion in the LVM2
> > tree.

I was certainly mistaken with that statement :)

I'll sort out all of your comments and repost.

> > +            exec 2> ./${SCRIPTNAME}.log
> 
> Errr ./ ???  What directory are we in and what file might we be clobbering?
> (Security blocker.)  Better to retain output from earlier runs too and
> ensure there's a timestamp of the run somewhere (cf. lvmdump).

Yes, this DEBUG functionality is not safe at all; not sure how I missed
this.

Mike


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]