[lvm-devel][PATCH] Add escape sequence for ':' in command's PV list

Alasdair G Kergon agk at redhat.com
Fri May 15 18:13:14 UTC 2009


On Fri, May 15, 2009 at 07:57:50PM +0200, Peter Rajnoha wrote:
> OK, thanks. I'll move the code to a separate function then and I'll add checks
> for pvcreate/vgcreate, too.
 
Main thing I'm bothered about here is applying a simple policy across the board.
Having different policies in different places is a recipe for confusion.

[Note that doubling the hyphens in device names does not set a precedent
as that is meant to be an internal tool matter, not exposed to the user who
uses /dev/vgname/lvname.]

How many more things need escaping?

Is the policy "any character that needs escaping will be doubled"?  

Or do we go for "any character that needs escaping will be preceded by a
backslash"?
(See config strings - does this work with config settings on cmdline too?)

Alasdair




More information about the lvm-devel mailing list