[lvm-devel] [PATCH] vgcfgbackup: do not produce corrupted metadata if PVs are missing
Petr Rockai
prockai at redhat.com
Tue May 19 05:53:39 UTC 2009
Milan Broz <mbroz at redhat.com> writes:
> Currently code uses pv_dev_name() for hash when getting internal
> "pvX" name.
>
> This produce corrupted metadata if PVs are missing, pv->dev
> is NULL and all these missing devices returns one name
> (using "unknown device" for all missing devices as hash key).
Good catch. Patch looks good (and comes with a test).
> Signed-off-by: Milan Broz <mbroz at redhat.com>
Acked-By: Petr Rockai <prockai at redhat.com>
--
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation
More information about the lvm-devel
mailing list