[lvm-devel] [PATCH] Un-export vg_read_internal.
Milan Broz
mbroz at redhat.com
Thu Nov 19 12:11:28 UTC 2009
On 11/02/2009 04:43 PM, Petr Rockai wrote:
> this was waiting a fairly long time for a round tuit, but here it is. This
> should properly banish vg_read_internal into confinement in metadata.c. Should
> be fairly obvious, I am just being paranoid here. (I made sure clvmd still
> compiles this time, too.)
> @@ -780,9 +780,9 @@ void lvm_do_backup(const char *vgname)
>
> pthread_mutex_lock(&lvm_lock);
>
> - vg = vg_read_internal(cmd, vgname, NULL /*vgid*/, &consistent);
> + vg = vg_read(cmd, vgname, NULL /*vgid*/, 0 /*flags*/);
>
> - if (vg && consistent)
> + if (!vg_read_error(vg))
> check_current_backup(vg);
Cannot this slightly change when remote meatadata backup is run? (missing PVs?)
But it is not problem IMHO.
ACK.
Milan
--
mbroz at redhat.com
More information about the lvm-devel
mailing list