[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] [PATCH] hint at --removemissing



Hi,

a trivial patch that wibbles the error message for the case when we are
trying to change a VG with missing PVs in it.

Index: lib/metadata/metadata.c
===================================================================
RCS file: /cvs/lvm2/LVM2/lib/metadata/metadata.c,v
retrieving revision 1.296
diff -u -p -r1.296 metadata.c
--- lib/metadata/metadata.c	19 Nov 2009 12:13:37 -0000	1.296
+++ lib/metadata/metadata.c	19 Nov 2009 12:14:57 -0000
@@ -3378,8 +3378,8 @@ static struct volume_group *_vg_lock_and
 
 	if (!cmd->handles_missing_pvs && vg_missing_pv_count(vg) &&
 	    (lock_flags & LCK_WRITE)) {
-		log_error("Cannot change VG %s while PVs are missing!",
-			  vg->name);
+		log_error("Cannot change VG %s while PVs are missing.", vg->name);
+		log_error("Consider vgreduce --removemissing.");
 		failure |= FAILED_INCONSISTENT; /* FIXME new failure code here? */
 		goto_bad;
 	}
Yours,
   Petr.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]