[lvm-devel] [PATCH] Do not try to unlock VG which is not locked.
Milan Broz
mbroz at redhat.com
Tue Nov 24 15:38:03 UTC 2009
If the vg_read() returned error, no lock was taken,
so always call vg_release().
Otherwise this can happen because of missing FAILED_*:
# vgchange -a y x --ignorelockingfailure
Volume group "x" not found
Internal error: Attempt to unlock unlocked VG x
Signed-off-by: Milan Broz <mbroz at redhat.com>
---
tools/toollib.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tools/toollib.c b/tools/toollib.c
index 39a6d69..33daf30 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -452,8 +452,7 @@ static int _process_one_vg(struct cmd_context *cmd, const char *vg_name,
ret_max = ret;
out:
- if ((vg_read_error(vg) == FAILED_ALLOCATION)||
- (vg_read_error(vg) == FAILED_LOCKING))
+ if (vg_read_error(vg))
vg_release(vg);
else
unlock_and_release_vg(cmd, vg, vg_name);
--
1.6.5.3
More information about the lvm-devel
mailing list