[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Optionally abort on internal errors.



On Sun, Nov 29, 2009 at 09:34:11PM +0100, Milan Broz wrote:
> +	if (level <= _LOG_ERR && !strncmp(format, "Internal error:",
> +					  strlen("Internal error:")))
> (why strlen? just len or better #define the string)
 
#define LOG_INTERNAL_ERR "Internal error: "

These messages may occur at any log level.
In normal circumstances not all of them prevent the program proceeding,
but all should be fatal if this option is set.

> - maybe only activate that when in debug (verbose mode)?

Too confusing.  Control via --config should be sufficient for now.
 
Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]