[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 01/13] Replicator: export out_ function for modules



On Mon, Oct 05, 2009 at 04:00:28PM +0200, Zdenek Kabelac wrote:
> +/* insert new line */
> +int out_newline(struct formatter *f)
> +{
> +	outnl(f);
> +	return 0;

Should return 1 here, and the caller has to check that.
Instead, I think the outnl macro should be changed to work like the outf one.
(make the 'f->nl' part internal to an export.c function instead of the header file)
The idea was that the callers would be using this so frequently, it was
clearer just writing 'outf(...)'  than 'if (!out_text(...)) return_0;' everywhere.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]