[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 02/13] Replicator: add libdm support



Hi,

Zdenek Kabelac <zkabelac redhat com> writes:
>  	case SUSPEND_WITH_LOCKFS:
> -		if (!dm_tree_suspend_children(root, dlid, ID_LEN + sizeof(UUID_PREFIX) - 1))
> +		if (!dm_tree_suspend_children(root, dlid, ID_LEN + sizeof(UUID_PREFIX) - 1, 0))
other than the API change Alasdair pointed out, this bit here changes existing
behaviour (although it may turn out to not affect anything, it would at least
deserve a comment as to why only priority 0 targets should be suspended).

Please also note that just calling this twice, once for 0 and once for 1 does
not correspond to pre-existing behaviour either (it constitutes an ordering
change).

Yours,
   Petr.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]