[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 02/11] debian: drop realtime



On Sat, 2009-10-10 at 11:21 +0200, Bastian Blank wrote:
> On Fri, Oct 09, 2009 at 05:24:48PM +0100, Alasdair G Kergon wrote:
> > On Fri, Oct 09, 2009 at 05:03:11PM +0200, Bastian Blank wrote:
> > > The code is not used. Why is it there?
> > This is an upstream development tree and instead of having multiple
> > branches, we keep the code in one place but exclude or disable code that
> > is not used.
> 
> The code
> * is enabled by default,
> * is unused in the published code since a long time and
> * is not marked in any way.
> => Can be removed.
> 
> >               The code that needed to use that particular feature has
> > not been finished.
> 
> Then it can be handled as part of that particular feature.
> 
> Bastian
> 

this patch should make everybody happy.

Sets realitime support off by default and still allow to have it
configurable for developers.

Fabio
diff --git a/configure.in b/configure.in
index b4e7f28..dd40110 100644
--- a/configure.in
+++ b/configure.in
@@ -40,7 +40,6 @@ case "$host_os" in
 		ODIRECT=yes
 		DM_IOCTLS=yes
 		SELINUX=yes
-		REALTIME=yes
 		CLUSTER=internal
 		FSADM=yes
 		;;
@@ -55,7 +54,6 @@ case "$host_os" in
 		ODIRECT=no
 		DM_IOCTLS=no
 		SELINUX=no
-		REALTIME=no
 		CLUSTER=none
 		FSADM=no
 		;;
@@ -318,7 +316,7 @@ AC_MSG_RESULT($READLINE)
 ################################################################################
 dnl -- Disable realtime clock support
 AC_MSG_CHECKING(whether to enable realtime support)
-AC_ARG_ENABLE(realtime, [  --disable-realtime      Disable realtime clock support],
+AC_ARG_ENABLE(realtime, [  --enable-realtime      Enable realtime clock support],
 REALTIME=$enableval)
 AC_MSG_RESULT($REALTIME)
 
diff --git a/lib/Makefile.in b/lib/Makefile.in
index 2bd6fba..9913464 100644
--- a/lib/Makefile.in
+++ b/lib/Makefile.in
@@ -82,7 +82,6 @@ SOURCES =\
 	misc/lvm-globals.c \
 	misc/lvm-string.c \
 	misc/lvm-wrappers.c \
-	misc/timestamp.c \
 	misc/util.c \
 	mm/memlock.c \
 	report/report.c \
@@ -90,6 +89,11 @@ SOURCES =\
 	uuid/uuid.c \
 	zero/zero.c
 
+ifeq ("@HAVE_REALTIME@", "yes")
+  SOURCES +=\
+	misc/timestamp.c
+endif
+
 ifeq ("@LVM1@", "internal")
   SOURCES +=\
 	format1/disk-rep.c \

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]