[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 08/11] debian: use selinux pkgconfig info instead of hardcoding



On Mon, Oct 12, 2009 at 11:06:58AM +0200, Fabio M. Di Nitto wrote:
> For the internal view, we can switch to use PKG_CONFIG inside our
> configure.in, but that means:
> 1) it will be a hard dependency (and we recently agreed to avoid that).
> 2) we assume that lvm2 developers and packagers will build/ship with
> recent enough build dependencies to guarantee working pkg-config files.
 
So any switch would still need a fallback for when pkgconfig is not
available.  (The real question is whether pkgconfig was generally
available some time before selinux or not.  If it was, then you can
argue that everyone with access to selinux also has access to pkgconfig.)

> For the external view, as it is now, we can create the correct .pc file.
> If we detect that selinux has pkg-config support, then we use the
> "Requires.private: libselinux" that will automatically expand via
> pkg-config. If we don't have selinux pkg-config, then we can hardcode as
> we do now.
 
Yes.

Alasdair


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]