[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg.



On Fri, 2010-04-02 at 02:23 +0100, Alasdair G Kergon wrote:
> On Thu, Apr 01, 2010 at 05:57:30PM -0400, Dave Wysochanski wrote:
> > lvm2app needs a link back to the vg in order to use the vg handle for
> > memory allocations as well as other things.  This patch adds the field
> > to struct physical_volume, and sets the field when returning from
> > vg_read() internal library call.
>  
> > +	struct volume_group *vg; /* FIXME: Only valid when used with lvm2app. */
> 
> Please make it generally applicable and always internally consistent i.e.
> always pointing back to the VG struct which contains the list it is on.
> 

Oh - this FIXME is an erroneous comment - sorry.  Originally I had
approached it this way, then changed it to be more general.  I could
have missed something though.

> Also update vg_validate whenever extending the core metadata structs.
> 

Will do so - thanks for the reminder.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]