[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] fix topology test to work again



Hi,

Mike Snitzer <snitzer redhat com> writes:
> Reintroduce teardown_() because t-topology-support.sh only needs a
> subset of the full teardown() between each iteration of the topology
> tests -- in particular the $TESTDIR must not get removed between each
> topology test iteration.

I would prefer to have prepare_scsi_debug_dev changed to drop the
devices and re-create them when invoked for the second time than to bend
the teardown mechanism for something it is not intended for. Also,
teardown/teardown_ is a poor distinction and does not say much about
intended usage. You can of course re-use parts of teardown in your
implementation, but please name the new function(s) appropriately in
that case.

> Also fix (and simplify) the unsafe scsi-debug device discovery in
> prepare_scsi_debug_dev().
Looks better indeed.

Yours,
   Petr.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]