[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] Using glibc regex

On Tue, Apr 20, 2010 at 04:07:00PM +0200, Zdenek Kabelac wrote:
> This patch replaces internal  dm_regex and uses  glibc regex routines so we
> achieve better performance for things like hundreds patterns.
How about getting 3 versions of this code into the tree in parallel
for a while?

   1) current cvs with optimiser
   2) new ejt dfa changes
   3) glibc regex

Put the bits that differ into separate files, keeping the tree reasonably
clean but not worrying too much about refactoring to avoid code
duplication - eventually two out of the three will be thrown away.

When we want to match a string, test against all 3 engines and if the
results differ, report the details and take the majority answer.
(A standard configure/lvm.conf setting could control which of the 3 are used.)
We could generate timing statistics too for all three (extend
lib/misc/timestamp,c) dumped when the process exits.

With all three enabled by default, the additional overhead shouldn't matter for
most people - it should be absorbed within the speedups we've recently
obtained so the sum of the 3 ought to still run faster than the 1 did


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]