[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Specified PVs being ignored when performing mirror split (bug 619221)



> On Aug 5, 2010, at 4:31 PM, Takahiro Yasui wrote:
>> # lvconvert --splitmirrors 1 --name new vg/org /dev/sda /dev/sdb
>>    vg/org: Mirror volume consists of legs C, D and A   (leg C is  
>> primary)
>>    vg/new: Linear volume consists of B
>>
>> Is this change OK? If the answer is yes, I just ask you to change  
>> the comments
>> of _move_removable_mimages_to_end().
> 
> Are you sure?  I've just tried this on my test box, and it behaves as  
> expected...
> 
> I had thought that I tested your scenario only with one PV specified,  
> and that perhaps it was the second (unnecessary) one that was throwing  
> off the logic.  However, that doesn't seem to be the case.

You are right. It behaves as expected if one PV is specified. Specifying
two PVs to split just one PV might not be usual, but I just wanted to ask
you if it is not a problem, because it changes the structure of the original
mirror. If you think it is OK, I ask you to update comments of
_move_removable_mimages_to_end().

Thank you for your reply.
Taka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]