[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Specified PVs being ignored when performing mirror split (bug 619221)




On Aug 5, 2010, at 5:09 PM, Takahiro Yasui wrote:

On 08/05/10 17:49, Jonathan Brassow wrote:
Whether my patch works or not may be irrelevant if your patch is
better.  I had considered going through the list backwards to save
some processing, but decided to go with the other method...  If this
works equally well, let's do it this way instead, yes?

Let me tell you the difference of behavior of yours and mine. When
the original volume has five devices, A,B,C,D,E and D and E are
specified as removable devices:

Your patch generates:
   orginal volume -> A,B,C
   new volume -> D,E

My suggestion generates:
   orginal volume -> A,B,C
   new volume -> E,D

If we have to care the order of new devices, I think your patch is better.

I don't think we do because they get renamed along with the new volume. Will repost new patch shortly.

 brassow


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]