[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Fix zombie mirror poll daemon (bug 585328)



On 08/25/2010 11:33 PM, Jonathan Brassow wrote:
> -	if (!lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent,
> +	if (!(lv->status & MIRRORED) ||
> +	    !lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent,
>  			       &percent_range, &event_nr) ||
>  	    (percent_range == PERCENT_INVALID)) {
>  		log_error("ABORTING: Mirror percentage check failed.");

why not move this check inside lv_mirror_percent?
(or is this only place where the bug can appear?)

(and it should probably use !lv_is_mirrored(lv) instead of mask)

otherwise ack

Milan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]