[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH] Do not scan snapshot origin for labels while 'ignore_suspended_devices()' is set



Milan Broz <mbroz redhat com> writes:

> On 08/25/2010 04:38 PM, Jonathan Brassow wrote:
>
>> +		 * Snapshot origin could be sitting on top of a mirror which
>> +		 * could be blocking I/O.  Skip snapshot origins entirely for
>> +		 * now.
>> +		 *
>> +		 * FIXME: rather than skipping origin, check if mirror is
>> +		 * underneath and if the mirror is blocking I/O.
>> +		 */
>> +		if (target_type && !strcmp(target_type, "snapshot-origin") &&
>> +		    ignore_suspended_devices()) {
>> +			log_debug("%s: Snapshot-origin device %s not usable.",
>> +				  dev_name(dev), name);
>> +			goto out;
>
> Well, if no one can find situation where this breaks some existing config,
> let's try that - we need something working in this release.
>
> The code need rewrite here anyway... ack from me for now.

Well, stacked PVs will break in some (rare) corner cases with the above
change. Nevertheless, we can probably get away with this for now (since
stacked PVs don't work very well anyway).

Reviewed-By: Petr Rockai <prockai redhat com>

Yours,
   Petr.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]