[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[lvm-devel] [PATCH 09/20] Replace stack trace with failure exit path



WARNING: functional change!

It looks like bug - an error return should be here
 - but the code currently ignores fail in engine construction
 - is there any use of rfilter without engine ?

Signed-off-by: Zdenek Kabelac <zkabelac redhat com>
---
 lib/filters/filter-regex.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/filters/filter-regex.c b/lib/filters/filter-regex.c
index d7c079e..e046c71 100644
--- a/lib/filters/filter-regex.c
+++ b/lib/filters/filter-regex.c
@@ -137,7 +137,7 @@ static int _build_matcher(struct rfilter *rf, const struct config_value *val)
 	 */
 	if (!(rf->engine = dm_regex_create(rf->mem, (const char **) regex,
 					   count)))
-		stack;
+		goto_out;
 	r = 1;
 
       out:
-- 
1.7.3.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]