[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 04/23] Remove dead assignment of lock_flags



Dne 21.12.2010 17:20, Milan Broz napsal(a):
> On 12/21/2010 04:41 PM, Zdenek Kabelac wrote:
>> @@ -204,7 +203,6 @@ static int lock_vg(struct local_client *client)
>>  
>>      lock_cmd = args[0] & (LCK_NONBLOCK | LCK_HOLD | LCK_SCOPE_MASK | LCK_TYPE_MASK);
>>      lock_mode = ((int)lock_cmd & LCK_TYPE_MASK);
>> -    lock_flags = args[1];
>>      lockname = &args[2];
> 
> I intentionally kept unused args[1] here because it is clear how the request look like
> without searching code, IOW
> 
> - 0 byte is command
> - 1 byte flags
> - 2 lockname
> 
> So any possible changes is easy on place.
> Yes, it should be struct and should use some friendly names. But now there is byte array...
> 
> Complier is clever enough to remove that code.
> 
> I do not care what some stupid static analysis says, the code is more readable with
> "dead" variable for me.

I always thought that's why /* comments */  were invented ;) for things like
this, but anyway in this case if you prefer to keep the unused value present -
I'll hide it only for my local scan-builds :)

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]