[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [lvm-devel] [PATCH 09/23] Add test for errors in _setup_task



Dne 21.12.2010 18:12, Milan Broz napsal(a):
> On 12/21/2010 04:41 PM, Zdenek Kabelac wrote:
>> -	if (uuid && *uuid)
>> -		dm_task_set_uuid(dmt, uuid);
>> +	if (uuid && *uuid && !dm_task_set_uuid(dmt, uuid))
>> +		goto_out;
> 
> Shouldn't it fail if uuid is requested but it is empty string?
> (but that's another problem:-)
> 

If this is invalid combination:

(uuid && (!*uuid || !dm_task_set_uuid())

Zdenek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]